Skip to content

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Jun 25, 2025

Motivation

The following statement currently shows a warning:

>> timestamps = types.untyped.DataPipe('data', 1:10, 'maxSize', inf);
>> ts = types.core.TimeSeries('timestamps', timestamps);
Warning: Invalid shape for property "timestamps". The maxSize of this DataPipe has a valid shape but the actual size of the dataPipe is not valid: Value of size [1
10] is invalid.  Must be one of:
    - Rank 1 with dimensions of size: [Any] 
> In types.util.validateShape (line 52)
In types.core/TimeSeries/validate_timestamps (line 246)
In types.core/TimeSeries/set.timestamps (line 193)
In types.core.TimeSeries (line 111) 

However, the actual shape can not be 1D for MATLAB vectors, and this PR fixes this by not enforcing 1D shape when validating the actual shape of a DataPipe object

How to test the behavior?

This should not display a warning:

>> timestamps = types.untyped.DataPipe('data', 1:10, 'maxSize', inf);
>> ts = types.core.TimeSeries('timestamps', timestamps);

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.56%. Comparing base (148eb7b) to head (67ae1c6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files         182      182           
  Lines        6384     6386    +2     
=======================================
+ Hits         6101     6103    +2     
  Misses        283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehennestad ehennestad marked this pull request as ready for review October 25, 2025 08:25
@ehennestad ehennestad requested a review from bendichter October 25, 2025 12:21
@bendichter bendichter merged commit 1256138 into main Oct 27, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants